Tornado: StaticFileHandler follows symlinks outside static root (path traversal)
What fixes it
A fixed version on one release line is not the upgrade target for every line. Check your exact version and any vendor backports.
Description
Summary
StaticFileHandler allows an unauthenticated attacker to read arbitrary files from the server's filesystem by requesting a path that resolves to a symbolic link placed inside the static root directory. Any application that serves user-uploadable content, or whose static directory is populated by a build/deploy pipeline that creates symlinks (e.g. npm link, webpack, Docker volume mounts, CDN sync tools), is affected. An attacker who can trigger the creation of a symlink pointing outside the static root—or exploit one that already exists—can retrieve sensitive files such as /etc/passwd, private keys, configuration files, or application secrets.
Details
The vulnerability is in tornado.web.StaticFileHandler, specifically in the interaction between two methods in [tornado/web.py](vscode-webview://1grdaaa6v64itrol06qu70pq3d1b9h9im5c3npvvc9snaprc1q9f/tornado/web.py):
- get_absolute_path uses
os.path.abspath()to resolve the requested path: - validate_absolute_path uses the same
os.path.abspath()on the root, then performs a string prefix check:
os.path.abspath() normalises . and .. segments but does not resolve symbolic links. As a result, a path like /var/www/static/link passes the startswith("/var/www/static/") check regardless of where link actually points.
Immediately after, os.path.exists() and os.path.isfile() do follow symlinks, so the file they ultimately open is the symlink's target. The fix would be to replace os.path.abspath() with os.path.realpath() in both methods, so the resolved real path of the symlink target is validated against the root, not just its string representation inside the static directory.
PoC
_Complete instructions, including specific configuration details, to reproduce the vulnerability._ Prerequisites: Python 3.x, Tornado installed.
- Create the environment
mkdir -p /tmp/static echo "DB_PASSWORD=s3cr3t" > /tmp/secret.conf ln -s /tmp/secret.conf /tmp/static/config.conf
- Minimal vulnerable server (server.py):
import tornado.web, tornado.ioloop
app = tornado.web.Application([
(r"/static/(.*)", tornado.web.StaticFileHandler, {"path": "/tmp/static"}),
])
app.listen(8888)
tornado.ioloop.IOLoop.current().start()- Exploit:
curl http://localhost:8888/static/config.conf
Impact
Any application using StaticFileHandler is potentially affected if:
- the static directory contains symlinks pointing outside it (common with build tooling), or
- the application allows file uploads into the static directory without stripping symlinks.
An unauthenticated remote attacker can read any file readable by the process user: application secrets, private TLS keys, database credentials, /etc/shadow, SSH keys, or source code (depending on the process's filesystem permissions).
Text from GitHub Advisory Database
Affected versions 52
- tornado, pip<= 6.5.8GitHub
- tornado, PyPIfrom first release, fixed in 6.5.9OSV
- tornado, PyPI0.2OSV
- tornado, PyPI1.0OSV
- tornado, PyPI1.1OSV
- tornado, PyPI1.1.1OSV
- tornado, PyPI1.2OSV
- tornado, PyPI1.2.1OSV
- tornado, PyPI2.0OSV
- tornado, PyPI2.1OSV
- tornado, PyPI2.1.1OSV
- tornado, PyPI2.2OSV
- tornado, PyPI2.2.1OSV
- tornado, PyPI2.3OSV
- tornado, PyPI2.4OSV
- tornado, PyPI2.4.1OSV
- tornado, PyPI3.0OSV
- tornado, PyPI3.0.1OSV
- tornado, PyPI3.0.2OSV
- tornado, PyPI3.1OSV
- tornado, PyPI3.1.1OSV
- tornado, PyPI3.2OSV
- tornado, PyPI3.2.1OSV
- tornado, PyPI3.2.2OSV
- tornado, PyPI4.0OSV
- tornado, PyPI4.0.1OSV
- tornado, PyPI4.0.2OSV
- tornado, PyPI4.1OSV
- tornado, PyPI4.1b2OSV
- tornado, PyPI4.2OSV
- tornado, PyPI4.2.1OSV
- tornado, PyPI4.2b1OSV
- tornado, PyPI4.3OSV
- tornado, PyPI4.3b1OSV
- tornado, PyPI4.3b2OSV
- tornado, PyPI4.4OSV
- tornado, PyPI4.4.1OSV
- tornado, PyPI4.4.2OSV
- tornado, PyPI4.4.3OSV
- tornado, PyPI4.4b1OSV
- tornado, PyPI4.5OSV
- tornado, PyPI4.5.1OSV
- tornado, PyPI4.5.2OSV
- tornado, PyPI4.5.3OSV
- tornado, PyPI4.5b1OSV
- tornado, PyPI4.5b2OSV
- tornado, PyPI5.0OSV
- tornado, PyPI5.0.1OSV
- tornado, PyPI5.0.2OSV
- tornado, PyPI5.0a1OSV
- tornado, PyPI5.0b1OSV
- tornado, PyPI5.1OSV
References 6
- github.com/tornadoweb/tornado/commit/437ab5f76565403b3403438d2e555d11f8128d32Fixvia GitHub
- github.com/tornadoweb/tornado/commit/f9f50b8bab265a2abf9f2415a3d2da6264a5450bFixvia GitHub
- github.com/tornadoweb/tornado/releases/tag/v6.5.9Fixvia GitHub
- github.com/tornadoweb/tornado/security/advisories/GHSA-c2m8-h5v5-343rAdvisoryvia GitHub
- github.com/advisories/GHSA-c2m8-h5v5-343rAdvisoryvia GitHub
- github.com/tornadoweb/tornado/pull/3719Referencevia GitHub