Linux: macsec: initialize SecY before registering the netdevice
What fixes it
- 2b42adf3b8ee9a0e1d2629aca3c5a02a1c438066LinuxCVE List
A fixed version on one release line is not the upgrade target for every line. Check your exact version and any vendor backports.
Description
In the Linux kernel, the following vulnerability has been resolved:
macsec: initialize SecY before registering the netdevice
Creating a MACsec device with MAC offload over an LRO-capable lower device triggers a warning in rtmsg_ifinfo_build_skb() when IPv4 forwarding is enabled by default.
register_netdevice() invokes inetdev_init(), which disables LRO and emits a NETDEV_FEAT_CHANGE notification. This reaches macsec_fill_info() before macsec_add_dev() initializes the SecY. key_len is still zero, so macsec_fill_info() returns -EMSGSIZE and trips the WARN_ON in rtmsg_ifinfo_build_skb(), even though the skb has enough space.
Even without the warning, notifications during registration can report uninitialized SecY attributes, including the SCI. This ordering has existed since the driver was introduced.
Initialize the SecY and apply the new-link attributes before registration. Move MAC address inheritance into macsec_newlink() so the SCI can also be initialized before registration-time notifications report it. Move the per-CPU statistics and metadata destination allocation into ndo_init(), and release partial allocations on failure.
Text from CVE List
Affected versions 8
- Linuxaffected: c09440f7dcb304002dfced8c0fea289eb25f2da0 before 2b42adf3b8ee9a0e1d2629aca3c5a02a1c438066CVE List
- Linuxaffected: c09440f7dcb304002dfced8c0fea289eb25f2da0 before b07bea42bf590edb0fd507ab25622a74af09548bCVE List
- Linuxaffected: c09440f7dcb304002dfced8c0fea289eb25f2da0 before c2de369c5c5b8599ca10fd5ca8d11fcd845c1331CVE List
- Linuxaffected: 4.6CVE List
- Linuxunaffected: all versions before 4.6CVE List
- Linuxunaffected: 6.18.55 through 6.18.*CVE List
- Linuxunaffected: 7.2.9 through 7.2.*CVE List
- Linuxunaffected: 7.3CVE List