Linux: bpf: Wait for an RCU tasks grace period before freeing trampoline progs
What fixes it
- 40955f6512a03f0e046f5256b0706b26ba191018LinuxCVE List
- 0fb5751a6e411b1b466c06e50021818d9391df98LinuxCVE List
- 5.11LinuxCVE List
- 5.12LinuxCVE List
A fixed version on one release line is not the upgrade target for every line. Check your exact version and any vendor backports.
Description
In the Linux kernel, the following vulnerability has been resolved:
bpf: Wait for an RCU tasks grace period before freeing trampoline progs
When a prog is detached from a trampoline, it is freed after an RCU grace period, or an RCU tasks trace one if it is sleepable. This covers the tasks that are running the prog, since the prog's enter helper takes the matching read lock before the prog is called. On a preemptible kernel, it doesn't cover a task that was preempted in the trampoline just before the enter helper. That task holds no lock yet, and it calls the prog after it was freed:
BUG: KASAN: vmalloc-out-of-bounds in __bpf_prog_enter_recur+0x3a5/0x3f0 Read of size 8 at addr ffffc90000055040 by task candidate/110 CPU: 1 UID: 0 PID: 110 Comm: candidate Not tainted 7.3.0-rc2-00014-g15071f2a1263-dirty #2 PREEMPT(full) Call Trace: <TASK> __bpf_prog_enter_recur+0x3a5/0x3f0 bpf_trampoline_6442509193+0x37/0xf1 __x64_sys_futex+0x9/0x410 do_syscall_64+0xb0/0x530 ...
Wait for an RCU tasks grace period before the existing one when freeing a prog that was linked to a trampoline. An RCU tasks grace period only ends once the tasks that were preempted have run again, and bpf_tramp_image_put() already relies on it to free the image. It doesn't wait for tasks that sleep in the trampoline, the next commit takes care of those.
Only progs that were linked to a trampoline can be called this way, so bpf_trampoline_add_prog() marks them and other progs are still freed as before.
Text from CVE List
Affected versions 10
- Linuxaffected: e21aa341785c679dd409c8cb71f864c00fe6c463 before 40955f6512a03f0e046f5256b0706b26ba191018CVE List
- Linuxaffected: e21aa341785c679dd409c8cb71f864c00fe6c463 before 0fb5751a6e411b1b466c06e50021818d9391df98CVE List
- Linuxaffected: e21d2b92354b3cd25dd774ebb0f0e52ff04a7861CVE List
- Linuxaffected: 85d177f56e5256e14b74a65940f981f6e3e8bb32CVE List
- Linuxaffected: 5.10.28 before 5.11CVE List
- Linuxaffected: 5.11.11 before 5.12CVE List
- Linuxaffected: 5.12CVE List
- Linuxunaffected: all versions before 5.12CVE List
- Linuxunaffected: 7.2.10 through 7.2.*CVE List
- Linuxunaffected: 7.3CVE List