Linux: usb: typec: tcpm: recover after failure to start the frs ams
What fixes it
- 184d842121e7d1fbc3a81895f36f72fa27444163LinuxCVE List
- 90156585765b29304f07b0e4a1c56a969876fcfcLinuxCVE List
A fixed version on one release line is not the upgrade target for every line. Check your exact version and any vendor backports.
Description
In the Linux kernel, the following vulnerability has been resolved:
usb: typec: tcpm: recover after failure to start the frs ams
Reset the port if the tcpm fails to start the FAST_ROLE_SWAP AMS by initiating error recovery on it.
This helps in cases where some cables (incorrectly) signal an FRS to an FRS capable port during disconnection. The TCPC autonomously starts sourcing VBUS on detecting the FRS signal. However, the VBUS sourcing is left on when the FAST_ROLE_SWAP AMS fails to start (as tcpm_sink_tx_ok is 0 as CC is open due to the cable disconnect). This is because the code sets the state to INVALID_STATE without resetting the port state.
Log snippet before changes: [ 101.401960] AMS FAST_ROLE_SWAP start [ 101.401971] Sink TX No Go [ 101.401982] sourcing vbus [ 101.401987] VBUS on [ 101.402159] VBUS on [ 109.257809] CC1: 0 -> 0, CC2: 5 -> 0 [state SNK_READY, polarity 1, disconnected] [ 111.267442] VBUS on
After changes: [ 70.541211] AMS FAST_ROLE_SWAP start [ 70.541220] Sink TX No Go [ 70.541228] state change SNK_READY -> ERROR_RECOVERY [rev3 NONE_AMS] [ 70.541362] VBUS on [ 70.541365] sourcing vbus [ 70.541367] VBUS on [ 70.541374] state change ERROR_RECOVERY -> PORT_RESET [rev3 NONE_AMS] [ 70.541410] disable vbus discharge ret:0 [ 70.543028] Setting usb_comm capable false [ 70.544009] Setting voltage/current limit 0 mV 0 mA [ 70.544034] polarity 0 [ 70.544239] Requesting mux state 0, usb-role 0, orientation 0 [ 70.555550] cc:=0 [ 70.555595] pending state change PORT_RESET -> PORT_RESET_WAIT_OFF @ 100 ms [rev3 NONE_AMS] [ 70.555697] VBUS off [ 70.555702] VBUS VSAFE0V [ 70.555762] CC1: 5 -> 0, CC2: 0 -> 0 [state PORT_RESET, polarity 0, disconnected] [ 70.587794] VBUS off [ 70.587799] VBUS VSAFE0V [ 70.655672] state change PORT_RESET -> PORT_RESET_WAIT_OFF [delayed 100 ms] [ 70.655682] state change PORT_RESET_WAIT_OFF -> SNK_UNATTACHED [rev3 NONE_AMS] [ 70.655686] Start toggling [ 70.656274] CC1: 0 -> 0, CC2: 0 -> 0 [state TOGGLING, polarity 0, disconnected]
Text from CVE List
Affected versions 12
- Linuxaffected: 0908c5aca31eb5e0c72d7a5dba422629b88e877d before ae8aae45a39fcf2c64813652fcb062eace220712CVE List
- Linuxaffected: 0908c5aca31eb5e0c72d7a5dba422629b88e877d before 184d842121e7d1fbc3a81895f36f72fa27444163CVE List
- Linuxaffected: 0908c5aca31eb5e0c72d7a5dba422629b88e877d before b2ed8643face247e513fad12e193378ba67a61a1CVE List
- Linuxaffected: 0908c5aca31eb5e0c72d7a5dba422629b88e877d before d6b0cce612636f79f2cf0652fce40a0cbff7f0edCVE List
- Linuxaffected: 0908c5aca31eb5e0c72d7a5dba422629b88e877d before 90156585765b29304f07b0e4a1c56a969876fcfcCVE List
- Linuxaffected: 5.12CVE List
- Linuxunaffected: all versions before 5.12CVE List
- Linuxunaffected: 6.6.160 through 6.6.*CVE List
- Linuxunaffected: 6.12.113 through 6.12.*CVE List
- Linuxunaffected: 6.18.56 through 6.18.*CVE List
- Linuxunaffected: 7.2.10 through 7.2.*CVE List
- Linuxunaffected: 7.3CVE List
References 5
- git.kernel.org/stable/c/ae8aae45a39fcf2c64813652fcb062eace220712Referencevia CVE List
- git.kernel.org/stable/c/184d842121e7d1fbc3a81895f36f72fa27444163Referencevia CVE List
- git.kernel.org/stable/c/b2ed8643face247e513fad12e193378ba67a61a1Referencevia CVE List
- git.kernel.org/stable/c/d6b0cce612636f79f2cf0652fce40a0cbff7f0edReferencevia CVE List
- git.kernel.org/stable/c/90156585765b29304f07b0e4a1c56a969876fcfcReferencevia CVE List