Linux: wifi: mac80211: drain PS delivery work during station teardown
What fixes it
- 843d3a1e6f25027ac85f88f67b95d82c67306deeLinuxCVE List
- 772bd89304ecf057cc51ce4ce24a1a96ac9c8de3LinuxCVE List
- 097460fcdd8ab9ef6f6018b2fdc29ba0ea499298LinuxCVE List
- 67a9e80c3ca20c9044cd6ee72cd6278dd19b5023LinuxCVE List
A fixed version on one release line is not the upgrade target for every line. Check your exact version and any vendor backports.
Description
In the Linux kernel, the following vulnerability has been resolved:
wifi: mac80211: drain PS delivery work during station teardown
Removing an AP or mesh station can notify the driver and wake TXQs after the station has already been removed from the driver, and can update num_sta_ps and the power-save queues after station cleanup has purged them.
sta_deliver_ps_frames() tests sta->dead only before it starts delivery. A worker that passes that test can be delayed while teardown sets sta->dead and removes the station from the driver; when it resumes it still runs the full delivery.
The existing cancel_work_sync() sits near the end of __cleanup_single_sta(), after the final driver state transition and after PS accounting and queue purging, so it drains the worker only once the state it has to protect has already changed. Before commit d34ba2168a3c ("mac80211: don't delay station destruction") cleanup was deferred through the same ordered workqueue as the delivery work, which kept the two ordered.
Cancel the work after setting sta->dead and before moving the driver state, and move the existing cancellation to the start of __cleanup_single_sta(). The first drain closes the driver-lifetime window; driver callbacks during the remaining state transitions can still queue drv_deliver_wk through ieee80211_sta_block_awake(), so retain the second drain at the start of __cleanup_single_sta(). That drain also covers insertion failures, which reach cleanup without setting sta->dead.
Text from CVE List
Affected versions 12
- Linuxaffected: d34ba2168a3c10e7301cca06069c39865b4c3ec6 before cbff71fe689f359ebd6a3eaded035ef75226afceCVE List
- Linuxaffected: d34ba2168a3c10e7301cca06069c39865b4c3ec6 before 843d3a1e6f25027ac85f88f67b95d82c67306deeCVE List
- Linuxaffected: d34ba2168a3c10e7301cca06069c39865b4c3ec6 before 772bd89304ecf057cc51ce4ce24a1a96ac9c8de3CVE List
- Linuxaffected: d34ba2168a3c10e7301cca06069c39865b4c3ec6 before 097460fcdd8ab9ef6f6018b2fdc29ba0ea499298CVE List
- Linuxaffected: d34ba2168a3c10e7301cca06069c39865b4c3ec6 before 67a9e80c3ca20c9044cd6ee72cd6278dd19b5023CVE List
- Linuxaffected: 3.14CVE List
- Linuxunaffected: all versions before 3.14CVE List
- Linuxunaffected: 6.6.160 through 6.6.*CVE List
- Linuxunaffected: 6.12.113 through 6.12.*CVE List
- Linuxunaffected: 6.18.56 through 6.18.*CVE List
- Linuxunaffected: 7.2.10 through 7.2.*CVE List
- Linuxunaffected: 7.3CVE List
References 5
- git.kernel.org/stable/c/cbff71fe689f359ebd6a3eaded035ef75226afceReferencevia CVE List
- git.kernel.org/stable/c/843d3a1e6f25027ac85f88f67b95d82c67306deeReferencevia CVE List
- git.kernel.org/stable/c/772bd89304ecf057cc51ce4ce24a1a96ac9c8de3Referencevia CVE List
- git.kernel.org/stable/c/097460fcdd8ab9ef6f6018b2fdc29ba0ea499298Referencevia CVE List
- git.kernel.org/stable/c/67a9e80c3ca20c9044cd6ee72cd6278dd19b5023Referencevia CVE List