Linux: iio: adc: ad_sigma_delta: fix use-after-free on unbind
What fixes it
- 975b09bc680acc60903777b766cdb53b0bf9c9f6LinuxCVE List
- 84500ae0d976995a6870cb1dca2d124b6b2d6e5aLinuxCVE List
- 5663c72bf400231e90777982216797191887a6b9LinuxCVE List
- 9ee8306121495d2a25aa5d1bfd519f2748786b83LinuxCVE List
A fixed version on one release line is not the upgrade target for every line. Check your exact version and any vendor backports.
Description
In the Linux kernel, the following vulnerability has been resolved:
iio: adc: ad_sigma_delta: fix use-after-free on unbind
ad_sd_buffer_postenable() allocates sigma_delta->samples_buf with devm_krealloc() at runtime, so its devres entry sits after all probe-time entries of the driver. devm resources are released in reverse allocation order, which means unbind frees samples_buf before iio_device_unregister() disables the buffers and detaches the trigger pollfunc. The data ready IRQ is still enabled at that point, so ad_sd_trigger_handler() can still run and memcpy() incoming samples into the freed samples_buf.
Fix this by preallocating the buffer in devm_ad_sd_setup_buffer_and_trigger(), before the triggered buffer and the IRQ are set up, so it is freed only after iio_device_unregister() has drained the trigger handler via free_irq(). Size it for the worst case of all sequencer slots being active; ad_sd_validate_scan_mask() already caps the number of active channels at num_slots.
This issue was found by an in-house static analysis tool.
Text from CVE List
Affected versions 12
- Linuxaffected: 8bea9af887de4c99a95f93f2ce400ef63e8b4e9b before 975b09bc680acc60903777b766cdb53b0bf9c9f6CVE List
- Linuxaffected: 8bea9af887de4c99a95f93f2ce400ef63e8b4e9b before 84500ae0d976995a6870cb1dca2d124b6b2d6e5aCVE List
- Linuxaffected: 8bea9af887de4c99a95f93f2ce400ef63e8b4e9b before f20b94a7dc1ff9ade191ce839c984210fdbdc653CVE List
- Linuxaffected: 8bea9af887de4c99a95f93f2ce400ef63e8b4e9b before 5663c72bf400231e90777982216797191887a6b9CVE List
- Linuxaffected: 8bea9af887de4c99a95f93f2ce400ef63e8b4e9b before 9ee8306121495d2a25aa5d1bfd519f2748786b83CVE List
- Linuxaffected: 5.19CVE List
- Linuxunaffected: all versions before 5.19CVE List
- Linuxunaffected: 6.6.160 through 6.6.*CVE List
- Linuxunaffected: 6.12.113 through 6.12.*CVE List
- Linuxunaffected: 6.18.56 through 6.18.*CVE List
- Linuxunaffected: 7.2.10 through 7.2.*CVE List
- Linuxunaffected: 7.3CVE List
References 5
- git.kernel.org/stable/c/975b09bc680acc60903777b766cdb53b0bf9c9f6Referencevia CVE List
- git.kernel.org/stable/c/84500ae0d976995a6870cb1dca2d124b6b2d6e5aReferencevia CVE List
- git.kernel.org/stable/c/f20b94a7dc1ff9ade191ce839c984210fdbdc653Referencevia CVE List
- git.kernel.org/stable/c/5663c72bf400231e90777982216797191887a6b9Referencevia CVE List
- git.kernel.org/stable/c/9ee8306121495d2a25aa5d1bfd519f2748786b83Referencevia CVE List