Linux: bpf: backtracking shouldn't clear outer frame R1-R5 for callbacks
What fixes it
- 1ac58dab0a83d2c64e3b807a3a0b399f17a74110LinuxCVE List
- 3a39bc9707fbd1bef4df7318a9d02222741dda5bLinuxCVE List
- 6.6.160LinuxCVE List
A fixed version on one release line is not the upgrade target for every line. Check your exact version and any vendor backports.
Description
In the Linux kernel, the following vulnerability has been resolved:
bpf: backtracking shouldn't clear outer frame R1-R5 for callbacks
When processing calls to bpf_loop() verifier marks R1 (and R4) as precise. R1 tracks loop iterations number and because of the 'callback_depth < R1' mechanics in check_helper_call() must be marked precise. However, precision propagation for R1 was broken, when bpf_loop() call was verified on a second iteration.
Consider the following verification trace:
- main: bpf_loop(nr_loops, callback ...)
- callback: BPF_EXIT
- main: bpf_loop(nr_loops, callback ...)
- ...
While the first visit of the call to bpf_loop() propagated R1 precision as expected, the second call to mark_chain_precision() in the check_helper_call() set R1, but it was immediately reset when backtrack_insn() processed preceding BPF_EXIT in the loop deleted in this patch.
Because of that, the second visit of the call to bpf_loop() injected checkpoint with R1 not marked as precise. Which could trick the verifier into accepting unsafe programs. See the next patch for an example of such program.
Commit is structured in a way to minimize conflicts when 'bpf' would be eventually merged with 'bpf-next'.
Text from CVE List
Affected versions 13
- Linuxaffected: b43550d7d58e7ae6618aaab18c1e912fa4d6e3dd before 1ac58dab0a83d2c64e3b807a3a0b399f17a74110CVE List
- Linuxaffected: ab5cfac139ab8576fb54630d4cca23c3e690ee90 before cdc93c6370f792d0649df2a145ac0cdcd430e411CVE List
- Linuxaffected: ab5cfac139ab8576fb54630d4cca23c3e690ee90 before 3a39bc9707fbd1bef4df7318a9d02222741dda5bCVE List
- Linuxaffected: ab5cfac139ab8576fb54630d4cca23c3e690ee90 before f83890dfed9efc5e19df1dbc1ad707a142936923CVE List
- Linuxaffected: ab5cfac139ab8576fb54630d4cca23c3e690ee90 before e3e4f66cc4b72333d0886ae2673c360248987889CVE List
- Linuxaffected: 6.6.15 before 6.6.160CVE List
- Linuxaffected: 6.7CVE List
- Linuxunaffected: all versions before 6.7CVE List
- Linuxunaffected: 6.6.160 through 6.6.*CVE List
- Linuxunaffected: 6.12.114 through 6.12.*CVE List
- Linuxunaffected: 6.18.57 through 6.18.*CVE List
- Linuxunaffected: 7.2.7 through 7.2.*CVE List
- Linuxunaffected: 7.3CVE List
References 5
- git.kernel.org/stable/c/1ac58dab0a83d2c64e3b807a3a0b399f17a74110Referencevia CVE List
- git.kernel.org/stable/c/cdc93c6370f792d0649df2a145ac0cdcd430e411Referencevia CVE List
- git.kernel.org/stable/c/3a39bc9707fbd1bef4df7318a9d02222741dda5bReferencevia CVE List
- git.kernel.org/stable/c/f83890dfed9efc5e19df1dbc1ad707a142936923Referencevia CVE List
- git.kernel.org/stable/c/e3e4f66cc4b72333d0886ae2673c360248987889Referencevia CVE List