Linux: net/mlx5e: Move representor vnic reporter to eswitch devlink port
What fixes it
- 7f26a5e8040b4957ef4dbdfcde6cc7ba2db53937LinuxCVE List
A fixed version on one release line is not the upgrade target for every line. Check your exact version and any vendor backports.
Description
In the Linux kernel, the following vulnerability has been resolved:
net/mlx5e: Move representor vnic reporter to eswitch devlink port
The representor vnic devlink health reporter is created and destroyed along the representor netdev (un)load path, which is not serialized by the devlink instance lock. Destroying the reporter from there triggers a devl_assert_locked() splat on driver unbind: WARNING: net/devlink/core.c:259 at devl_assert_locked+0x54/0x70, CPU#2: bash/3758 Modules linked in: mlx5_vdpa vringh vdpa mlx5_ib mlx5_fwctl mlx5_core ... CPU: 2 UID: 0 PID: 3758 Comm: bash Tainted: G W 6.19.0+ #1 PREEMPT Tainted: [W]=WARN Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), ... RIP: 0010:devl_assert_locked+0x54/0x70 Call Trace: <TASK> devl_health_reporter_destroy+0x3a/0x1b0 mlx5e_vport_rep_unload+0x12d/0x2b0 [mlx5_core] mlx5_eswitch_unregister_vport_reps+0x1b8/0x220 [mlx5_core] ? __esw_offloads_unload_rep+0x190/0x190 [mlx5_core] ? kernfs_remove_by_name_ns+0xc3/0xf0 device_release_driver_internal+0x3b2/0x560 unbind_store+0xce/0xf0
Move the reporter's lifecycle to the eswitch devlink port (un)register paths, which are already serialized by the devlink instance lock, and store the handle on mlx5_devlink_port. Use the port's mlx5_vport as the reporter priv since the diagnose callback only needs a device handle and a vport number, and mlx5_vport carries both and is initialized before any representor driver probes.
Text from CVE List
Affected versions 12
- Linuxaffected: cf14af140a5ad0937d385ce693100f33f02e9c54 before d552beb9d278aeb180d26c3889b6bd21444ad11eCVE List
- Linuxaffected: cf14af140a5ad0937d385ce693100f33f02e9c54 before fb52d58f7d6abc2f956d9c1ac472c709f7bb33c2CVE List
- Linuxaffected: cf14af140a5ad0937d385ce693100f33f02e9c54 before dcaba72c85c14fe7393a59d61695941e6ccbd7d7CVE List
- Linuxaffected: cf14af140a5ad0937d385ce693100f33f02e9c54 before d1fcff9b39bac188ef62a77ebd176484be928ec2CVE List
- Linuxaffected: cf14af140a5ad0937d385ce693100f33f02e9c54 before 7f26a5e8040b4957ef4dbdfcde6cc7ba2db53937CVE List
- Linuxaffected: 6.4CVE List
- Linuxunaffected: all versions before 6.4CVE List
- Linuxunaffected: 6.6.160 through 6.6.*CVE List
- Linuxunaffected: 6.12.114 through 6.12.*CVE List
- Linuxunaffected: 6.18.53 through 6.18.*CVE List
- Linuxunaffected: 7.2.7 through 7.2.*CVE List
- Linuxunaffected: 7.3CVE List
References 5
- git.kernel.org/stable/c/d552beb9d278aeb180d26c3889b6bd21444ad11eReferencevia CVE List
- git.kernel.org/stable/c/fb52d58f7d6abc2f956d9c1ac472c709f7bb33c2Referencevia CVE List
- git.kernel.org/stable/c/dcaba72c85c14fe7393a59d61695941e6ccbd7d7Referencevia CVE List
- git.kernel.org/stable/c/d1fcff9b39bac188ef62a77ebd176484be928ec2Referencevia CVE List
- git.kernel.org/stable/c/7f26a5e8040b4957ef4dbdfcde6cc7ba2db53937Referencevia CVE List