Linux: drm/drm_exec: fix up contended obj when num_objects is 0
What fixes it
- 506cfed91e50cc8055799480a2fde5a18f63a21cLinuxCVE List
- 831cd124ce99c3e61266bed30519d52f7c26abedLinuxCVE List
- 159720704d9d652b64390c11fb971e15b0a78d23LinuxCVE List
A fixed version on one release line is not the upgrade target for every line. Check your exact version and any vendor backports.
Description
In the Linux kernel, the following vulnerability has been resolved:
drm/drm_exec: fix up contended obj when num_objects is 0
drm_exec_prepare_array() silently returns success without calling drm_exec_lock_contended() when num_objects is zero. This breaks the invariant upheld by drm_exec_lock_obj(), where every entry point into the locking sequence must first attempt to lock any previously contended object before proceeding.
Drivers that chain multiple drm_exec_prepare_array() calls per drm_exec_until_all_locked() iteration (e.g. amdgpu's userq signal/wait ioctls, which prepare separate read and write BO arrays) can pass an empty array for one of the two calls. If contention is hit while preparing the non-empty array, exec->contended is set and the loop retries; on retry, the empty-array call preceding it is a no-op that never clears exec->contended, so drm_exec_retry_on_contention() immediately jumps back to the top of the loop without ever reaching the call that would resolve the contention. This spins forever.
Fix it by having drm_exec_prepare_array() call drm_exec_lock_contended() directly when num_objects is zero, so a pending contended object dont loop infinitely.
Text from CVE List
Affected versions 12
- Linuxaffected: 09593216bff15866f95c8ad406cb7fdcec1ee40a before 506cfed91e50cc8055799480a2fde5a18f63a21cCVE List
- Linuxaffected: 09593216bff15866f95c8ad406cb7fdcec1ee40a before 831cd124ce99c3e61266bed30519d52f7c26abedCVE List
- Linuxaffected: 09593216bff15866f95c8ad406cb7fdcec1ee40a before f3e74866018dab793ebee1fdf0ef34f7271d1f8cCVE List
- Linuxaffected: 09593216bff15866f95c8ad406cb7fdcec1ee40a before a565022c02f218ec9789c2baf4690792e7a48cbbCVE List
- Linuxaffected: 09593216bff15866f95c8ad406cb7fdcec1ee40a before 159720704d9d652b64390c11fb971e15b0a78d23CVE List
- Linuxaffected: 6.6CVE List
- Linuxunaffected: all versions before 6.6CVE List
- Linuxunaffected: 6.6.158 through 6.6.*CVE List
- Linuxunaffected: 6.12.111 through 6.12.*CVE List
- Linuxunaffected: 6.18.53 through 6.18.*CVE List
- Linuxunaffected: 7.2.7 through 7.2.*CVE List
- Linuxunaffected: 7.3CVE List
References 5
- git.kernel.org/stable/c/506cfed91e50cc8055799480a2fde5a18f63a21cReferencevia CVE List
- git.kernel.org/stable/c/831cd124ce99c3e61266bed30519d52f7c26abedReferencevia CVE List
- git.kernel.org/stable/c/f3e74866018dab793ebee1fdf0ef34f7271d1f8cReferencevia CVE List
- git.kernel.org/stable/c/a565022c02f218ec9789c2baf4690792e7a48cbbReferencevia CVE List
- git.kernel.org/stable/c/159720704d9d652b64390c11fb971e15b0a78d23Referencevia CVE List