Linux: smb: client: fix cifsFileInfo reference leak in deferred close
What fixes it
- 525c225e23d61694091f2806de553a69362a78ffLinuxCVE List
- 5520e89a5a4f834bced64cf2ac927001cc513a40LinuxCVE List
A fixed version on one release line is not the upgrade target for every line. Check your exact version and any vendor backports.
Description
In the Linux kernel, the following vulnerability has been resolved:
smb: client: fix cifsFileInfo reference leak in deferred close
When cifs_close() defers a close, it hands the cifsFileInfo reference of the closing struct file to the queued work. Each execution of smb2_deferred_work_close() drops one such reference.
deferred_close_scheduled can be false while the work is pending: the workqueue clears PENDING when the callback starts to run, before the callback clears the flag under deferred_lock. A close in that interval requeues the running work, and the callback then clears the flag, leaving the requeued work pending with the flag down. A later cifs_open() can reuse the handle and its cifs_close() reaches the same branch: queue_delayed_work() fails because the work is still pending, but cifs_close() returns without dropping the closing file's reference. The cifsFileInfo count stays pinned and its tlink, dentry and server handle are leaked.
Check the return value and hand off the reference only when work was actually queued. Otherwise, use the shared _cifsFileInfo_put(), like the mod_delayed_work() branch above: the pending execution already owns its reference.
This issue was found by an in-house static analysis tool.
Text from CVE List
Affected versions 12
- Linuxaffected: c3f207ab29f793b8c942ce8067ed123f18d5b81b before 525c225e23d61694091f2806de553a69362a78ffCVE List
- Linuxaffected: c3f207ab29f793b8c942ce8067ed123f18d5b81b before bbeb7a42c9ea656e17ddcbdc2d7917aa853383a6CVE List
- Linuxaffected: c3f207ab29f793b8c942ce8067ed123f18d5b81b before a6767712902beb0f53238be485971c9a83ea1079CVE List
- Linuxaffected: c3f207ab29f793b8c942ce8067ed123f18d5b81b before ea93759d6c2789924f4e557aed5be532207715eaCVE List
- Linuxaffected: c3f207ab29f793b8c942ce8067ed123f18d5b81b before 5520e89a5a4f834bced64cf2ac927001cc513a40CVE List
- Linuxaffected: 5.13CVE List
- Linuxunaffected: all versions before 5.13CVE List
- Linuxunaffected: 6.6.160 through 6.6.*CVE List
- Linuxunaffected: 6.12.113 through 6.12.*CVE List
- Linuxunaffected: 6.18.54 through 6.18.*CVE List
- Linuxunaffected: 7.2.7 through 7.2.*CVE List
- Linuxunaffected: 7.3CVE List
References 5
- git.kernel.org/stable/c/525c225e23d61694091f2806de553a69362a78ffReferencevia CVE List
- git.kernel.org/stable/c/bbeb7a42c9ea656e17ddcbdc2d7917aa853383a6Referencevia CVE List
- git.kernel.org/stable/c/a6767712902beb0f53238be485971c9a83ea1079Referencevia CVE List
- git.kernel.org/stable/c/ea93759d6c2789924f4e557aed5be532207715eaReferencevia CVE List
- git.kernel.org/stable/c/5520e89a5a4f834bced64cf2ac927001cc513a40Referencevia CVE List