Linux: pinctrl: mediatek: paris: bypass pinctrl GPIO layer in set GPIO direction
What fixes it
- 482ba972f9638f467df2d498b46384a1d1f80529LinuxCVE List
- 3c4897861759fd8bd81dc2ada92121ac76332592LinuxCVE List
- 428b031dad390edd5da729b9afd474a95dc4f76bLinuxCVE List
A fixed version on one release line is not the upgrade target for every line. Check your exact version and any vendor backports.
Description
In the Linux kernel, the following vulnerability has been resolved:
pinctrl: mediatek: paris: bypass pinctrl GPIO layer in set GPIO direction
pinctrl_gpio_direction_input() / pinctrl_gpio_direction_output() take the pinctrl mutex. This causes a gpiochip operations to need to sleep. Worse yet, the .can_sleep field in the gpiochip is not set. This causes the shared GPIO proxy to trip over, as it uses gpiod_cansleep() to check whether it can use a spinlock or needs a mutex. In this case, it ends up taking a spinlock, then calls pinctrl_gpio_direction_output(), which takes a mutex. This causes a huge warning.
While this class of Mediatek hardware does not have separate clear/set registers, the pinctrl context has a spinlock that is taken whenever a register read-modify-write is done. Also, once the GPIO function is selected / muxed in, further GPIO operations do not involve pinctrl operations or state. The GPIO direction and level values do not require toggling the pinmux or any other pin config options.
Switch to directly calling mtk_pinmux_gpio_set_direction() in the GPIO set direction callbacks to avoid taking the pinctrl mutex. Drop the .gpio_set_direction field in mtk_pmxops to signal we are no longer using the pinctrl GPIO layer for setting the direction.
Text from CVE List
Affected versions 10
- Linuxaffected: 805250982bb5c5ce4a6e52e1d87204c5feea0dd1 before 482ba972f9638f467df2d498b46384a1d1f80529CVE List
- Linuxaffected: 805250982bb5c5ce4a6e52e1d87204c5feea0dd1 before 3c4897861759fd8bd81dc2ada92121ac76332592CVE List
- Linuxaffected: 805250982bb5c5ce4a6e52e1d87204c5feea0dd1 before 428b031dad390edd5da729b9afd474a95dc4f76bCVE List
- Linuxaffected: 805250982bb5c5ce4a6e52e1d87204c5feea0dd1 before c87c9046c4e00d599454e033a477176c4d73ac2aCVE List
- Linuxaffected: 4.20CVE List
- Linuxunaffected: all versions before 4.20CVE List
- Linuxunaffected: 6.6.160 through 6.6.*CVE List
- Linuxunaffected: 6.12.114 through 6.12.*CVE List
- Linuxunaffected: 6.18.53 through 6.18.*CVE List
- Linuxunaffected: 7.2CVE List
References 4
- git.kernel.org/stable/c/482ba972f9638f467df2d498b46384a1d1f80529Referencevia CVE List
- git.kernel.org/stable/c/3c4897861759fd8bd81dc2ada92121ac76332592Referencevia CVE List
- git.kernel.org/stable/c/428b031dad390edd5da729b9afd474a95dc4f76bReferencevia CVE List
- git.kernel.org/stable/c/c87c9046c4e00d599454e033a477176c4d73ac2aReferencevia CVE List