Linux: nvme-fc: Do not cancel requests in io target before it is initialized
What fixes it
- 5488e2706c58444a24e15773237dcc0bedcd771fLinuxCVE List
A fixed version on one release line is not the upgrade target for every line. Check your exact version and any vendor backports.
Description
In the Linux kernel, the following vulnerability has been resolved:
nvme-fc: Do not cancel requests in io target before it is initialized
A new nvme-fc controller in CONNECTING state sees admin request timeout schedules ctrl->ioerr_work to abort inflight requests. This ends up calling __nvme_fc_abort_outstanding_ios() which aborts requests in both admin and io tagsets. In case fc_ctrl->tag_set was not initialized we see the warning below. This is because ctrl.queue_count is initialized early in nvme_fc_alloc_ctrl().
nvme nvme0: NVME-FC{0}: starting error recovery Connectivity Loss INFO: trying to register non-static key. The code is fine but needs lockdep annotation, or maybe lpfc 0000:ab:00.0: queue 0 connect admin queue failed (-6). you didn't initialize this object before use? turning off the locking correctness validator. Workqueue: nvme-reset-wq nvme_fc_ctrl_ioerr_work [nvme_fc] Call Trace: <TASK> dump_stack_lvl+0x57/0x80 register_lock_class+0x567/0x580 __lock_acquire+0x330/0xb90 lock_acquire.part.0+0xad/0x210 blk_mq_tagset_busy_iter+0xf9/0xc00 __nvme_fc_abort_outstanding_ios+0x23f/0x320 [nvme_fc] nvme_fc_ctrl_ioerr_work+0x172/0x210 [nvme_fc] process_one_work+0x82c/0x1450 worker_thread+0x5ee/0xfd0 kthread+0x3a0/0x750 ret_from_fork+0x439/0x670 ret_from_fork_asm+0x1a/0x30 </TASK>
Update the check in __nvme_fc_abort_outstanding_ios() confirm that io tagset was created before iterating over busy requests. Also make sure to cancel ctrl->ioerr_work before removing io tagset.
Text from CVE List
Affected versions 10
- Linuxaffected: 52793d62a696e9188092eb0817fb1219ee5729ff before 5488e2706c58444a24e15773237dcc0bedcd771fCVE List
- Linuxaffected: 52793d62a696e9188092eb0817fb1219ee5729ff before da930308b4bc24c335574e85ca84ff70a988cf05CVE List
- Linuxaffected: 52793d62a696e9188092eb0817fb1219ee5729ff before dd39064d2948b14dbe4f364fe4b3c9cfc632cc21CVE List
- Linuxaffected: 52793d62a696e9188092eb0817fb1219ee5729ff before ee38469f88492df99e1d97f03aa40ecfd218934fCVE List
- Linuxaffected: 5.10CVE List
- Linuxunaffected: all versions before 5.10CVE List
- Linuxunaffected: 6.6.158 through 6.6.*CVE List
- Linuxunaffected: 6.12.111 through 6.12.*CVE List
- Linuxunaffected: 6.18.53 through 6.18.*CVE List
- Linuxunaffected: 7.2CVE List
References 4
- git.kernel.org/stable/c/5488e2706c58444a24e15773237dcc0bedcd771fReferencevia CVE List
- git.kernel.org/stable/c/da930308b4bc24c335574e85ca84ff70a988cf05Referencevia CVE List
- git.kernel.org/stable/c/dd39064d2948b14dbe4f364fe4b3c9cfc632cc21Referencevia CVE List
- git.kernel.org/stable/c/ee38469f88492df99e1d97f03aa40ecfd218934fReferencevia CVE List