InvoiceShelf: Cross-company read/modify/delete of notes via missing company scope in NotePolicy (BOLA/IDOR)
What fixes it
No source in this snapshot names a fixed version. The vendor advisories under References are the place to check.
Description
InvoiceShelf is an open-source web & mobile app that helps track expenses, payments and create professional invoices and estimates. Prior to version 2.4.0, InvoiceShelf NotesController::show, NotesController::update, and NotesController::destroy authorize only the generic view notes or manage notes ability and do not pass the route-bound Note to NotePolicy::viewNotes or NotePolicy::manageNotes, so neither method checks the target note's company_id. Because the Note model has no global company scope, an authenticated staff user with ordinary note abilities can select another company's sequential note identifier and read, modify, or delete its reusable invoice, estimate, and payment note templates. This issue is fixed in version 2.4.0.
Text from CVE List
Affected versions 1
- InvoiceShelfaffected: < 2.4.0CVE List
References 4
- github.com/InvoiceShelf/InvoiceShelf/commit/e432e4e62f5aa52238e3ff3fc37a0c78588eec47Fixvia CVE List
- github.com/InvoiceShelf/InvoiceShelf/releases/tag/2.4.0Fixvia CVE List
- github.com/InvoiceShelf/InvoiceShelf/security/advisories/GHSA-85wc-38p4-2wqqAdvisoryvia CVE List
- github.com/InvoiceShelf/InvoiceShelf/pull/661Referencevia CVE List