InvoiceShelf: IDOR in InvoiceShelf estimate-to-invoice conversion allows any company user to read and tamper with other companies' estimates
What fixes it
- 2.4.0InvoiceShelf/InvoiceShelf, actionsGitHub
A fixed version on one release line is not the upgrade target for every line. Check your exact version and any vendor backports.
Description
InvoiceShelf is an open-source web & mobile app that helps track expenses, payments and create professional invoices and estimates. Prior to version 2.4.0, POST /api/v1/estimates/{estimate}/convert-to-invoice in ConvertEstimateController authorizes only the caller's create-invoice ability and does not authorize access to the route-bound Estimate. Because route-model binding can resolve an estimate from any company, an authenticated user with create-invoice ability can copy another company's line items, prices, totals, taxes, notes, currency, and customer data into an invoice in the attacker's company. The victim company's configured conversion action reaches checkForEstimateConvertAction and can also change or delete the original estimate. This issue is fixed in version 2.4.0.
Text from CVE List
Affected versions 2
- InvoiceShelfaffected: < 2.4.0CVE List
- InvoiceShelf/InvoiceShelf, actions< 2.4.0GitHub
References 4
- github.com/InvoiceShelf/InvoiceShelf/commit/e432e4e62f5aa52238e3ff3fc37a0c78588eec47Fixvia CVE List
- github.com/InvoiceShelf/InvoiceShelf/releases/tag/2.4.0Fixvia CVE List
- github.com/InvoiceShelf/InvoiceShelf/security/advisories/GHSA-j2vg-rxqr-5vc9Exploitvia CVE List
- github.com/InvoiceShelf/InvoiceShelf/pull/661Referencevia CVE List