nimiq-blockchain: Validity store off by one error
What fixes it
- 1.5.1nimiq-blockchain, rustGitHub
- 1.5.1nimiq-blockchain, crates.ioOSV
cargo update -p nimiq-blockchain --precise 1.5.1
A fixed version on one release line is not the upgrade target for every line. Check your exact version and any vendor backports.
Description
Impact
The validity store treats a transaction with stored block_number = X as "in window" only when X > last_bn - transaction_validity_window_blocks (strict inequality). However the protocol's Transaction::is_valid_at accepts a transaction for inclusion in any block in [validity_start_height - blocks_per_batch, validity_start_height + window - 1]. By choosing validity_start_height = X + blocks_per_batch (the largest value still compatible with first inclusion at block X), an attacker can replay the same signed transaction in any block B such that X + window < B < validity_start_height + window, i.e., a contiguous window of blocks_per_batch - 1 blocks (59 on MainNet, ~10 minutes) during which the replay-protection check fails to flag it. The same transaction is then executed twice: the sender is debited twice, the recipient credited twice.
Patches
https://github.com/nimiq/core-rs-albatross/pull/3772
Workarounds
No known workarounds
Text from GitHub Advisory Database
Affected versions 3
- nimiq-blockchain, rust<= 1.5.0GitHub
- core-rs-albatrossaffected: < 1.5.1CVE List
- nimiq-blockchain, crates.iofrom first release, fixed in 1.5.1OSV
References 4
- github.com/nimiq/core-rs-albatross/commit/a530b2434ebca6e3716f07c73079786fcc6f2e41Fixvia CVE List
- github.com/nimiq/core-rs-albatross/security/advisories/GHSA-3763-qp59-59vfAdvisoryvia CVE List
- github.com/advisories/GHSA-3763-qp59-59vfAdvisoryvia GitHub
- github.com/nimiq/core-rs-albatross/pull/3772Referencevia CVE List