@highcharts/dashboards: Highcharts Dashboards parses fullscreen labels as HTML
What fixes it
- 4.2.3@highcharts/dashboards, npmGitHub
npm install @highcharts/dashboards@4.2.3
A fixed version on one release line is not the upgrade target for every line. Check your exact version and any vendor backports.
Description
Impact
The edit mode fullscreen labels are parsed as HTML when the corresponding control is rendered. An attacker who controls the Dashboards language options can supply markup carrying event handlers, which then execute in the origin of the page hosting the dashboard. Exploitation requires that untrusted data reach the Dashboards language configuration and that the affected control be rendered. Script running this way has the same access to page data, storage and session state as the hosting application.
Workarounds
Until you can upgrade, replace Fullscreen.prototype.setButtonText atapplication startup. The replacement is the original method with textContent in place of innerHTML.
If you install Dashboards from npm
Import the module once, before any board is created.
import Fullscreen from '@highcharts/dashboards/es-modules/Dashboards/EditMode/Fullscreen.js';
Fullscreen.prototype.setButtonText = function () {
const editMode = this.board.editMode,
button = editMode?.tools.contextMenu?.items.viewFullscreen;
if (button?.innerElement) {
const lang = editMode.lang;
button.innerElement.textContent =
(this.isOpen ? lang.exitFullscreen : lang.viewFullscreen) || '';
}
};If you load Dashboards from a <script> tag
The same replacement, taking Fullscreen from the global namespace. It must run after modules/layout and before any board is created.
<script src="https://code.highcharts.com/dashboards/dashboards.js"></script>
<script src="https://code.highcharts.com/dashboards/modules/layout.js"></script>
<script>
{
const Fullscreen = window.Dashboards?.Fullscreen;
Fullscreen.prototype.setButtonText = function () {
const editMode = this.board.editMode,
button = editMode?.tools.contextMenu?.items.viewFullscreen;
if (button?.innerElement) {
const lang = editMode.lang;
button.innerElement.textContent =
(this.isOpen ? lang.exitFullscreen : lang.viewFullscreen) || '';
}
};
}
</script>If your application does not need Edit Mode, leaving it disabled (editMode.enabled: false) removes the exposure as well. The same applies to the context menu — the label is only reachable when viewFullscreen is among editMode.contextMenu.items.
Obtaining the patched version
The patched releases are available from all the usual distribution channels. With npm, upgrade the affected package to the patched version listed above, for example npm install @highcharts/dashboards@4.2.3. If you load Highcharts Dashboards from a CDN, use a versioned URL, for example https://code.highcharts.com/dashboards/4.2.3/dashboards.js. For more on each installation method, see the installation guide.
Text from GitHub Advisory Database
Affected versions 4
- @highcharts/dashboards, npm>= 1.0.0, < 4.2.3GitHub
- highchartsaffected: < 13.0.0-beta.2CVE List
- dashboardsaffected: >= 1.0.0, < 4.2.3CVE List
- @highcharts/dashboards, npmfrom 1.0.0, fixed in 4.2.3OSV
References 4
- github.com/highcharts/highcharts/commit/f97213bab745e40f628720c21f4e8b31ee3e768bFixvia CVE List
- github.com/highcharts/highcharts/releases/tag/dashboards-v4.2.3Fixvia CVE List
- github.com/highcharts/highcharts/security/advisories/GHSA-58g7-7f52-h92cAdvisoryvia CVE List
- github.com/advisories/GHSA-58g7-7f52-h92cAdvisoryvia GitHub