MariaDB Connector/Node.js: SQL injection in the text protocol when the session uses NO_BACKSLASH_ESCAPES
What fixes it
- 3.2.5mariadb, npmGitHub
npm install mariadb@3.2.5 - 3.3.4mariadb, npmGitHub
npm install mariadb@3.3.4 - 3.4.7mariadb, npmGitHub
npm install mariadb@3.4.7 - 3.5.4mariadb, npmGitHub
npm install mariadb@3.5.4
A fixed version on one release line is not the upgrade target for every line. Check your exact version and any vendor backports.
Description
Description
When escaping string and binary parameters for the text protocol, the connector always escaped the quote character with a backslash, without ever consulting the session's NO_BACKSLASH_ESCAPES SQL mode. The server status flag was declared (STATUS_NO_BACKSLASH_ESCAPES) but never read.
Under a server or session running with NO_BACKSLASH_ESCAPES, the backslash is an ordinary character and the quote must be escaped by doubling it. The escaped value produced by the connector therefore closed the string literal, and a value passed through a placeholder was interpreted as SQL.
All text-protocol escaping entry points were affected, including Connection.escape().
Impact
An attacker able to influence any value the application passes as a query parameter could execute arbitrary SQL with the privileges of the application's database user: read, modify or delete any data reachable by that connection.
Exposure requires a deployment where NO_BACKSLASH_ESCAPES is enabled — server-wide, through the connector's sessionVariables / initSql options, or by an application-issued SET sql_mode. It is not implied by the ANSI, ORACLE or TRADITIONAL compound modes on MariaDB 11.4, so it has to be set deliberately. Where it is enabled, no unusual application code is needed: the standard placeholder API is the injection point.
execute() and batch() are not affected: the binary prepared-statement and bulk protocols send parameter values out of band.
Resolution
The escaping routines now branch on the session status flag, doubling the quote and leaving the backslash untouched when NO_BACKSLASH_ESCAPES is set
Workarounds
Use execute() or batch(), or do not enable NO_BACKSLASH_ESCAPES, until upgraded.
Credit
Reported by fg0x0.
Text from GitHub Advisory Database
Affected versions 12
- mariadb, npm< 3.2.5GitHub
- mariadb, npm>= 3.3.0, < 3.3.4GitHub
- mariadb, npm>= 3.4.0, < 3.4.7GitHub
- mariadb, npm>= 3.5.0-rc.0, < 3.5.4GitHub
- mariadb-connector-nodejsaffected: < 3.2.5CVE List
- mariadb-connector-nodejsaffected: >= 3.3.0, < 3.3.4CVE List
- mariadb-connector-nodejsaffected: >= 3.4.0, < 3.4.7CVE List
- mariadb-connector-nodejsaffected: >= 3.5.0-rc.0, < 3.5.4CVE List
- mariadb, npmfrom first release, fixed in 3.2.5OSV
- mariadb, npmfrom 3.3.0, fixed in 3.3.4OSV
- mariadb, npmfrom 3.4.0, fixed in 3.4.7OSV
- mariadb, npmfrom 3.5.0-rc.0, fixed in 3.5.4OSV
References 12
- github.com/mariadb-corporation/mariadb-connector-nodejs/commit/6995c8cf8e51b2ad055de63dcaa4094eebbef5ceFixvia CVE List
- github.com/mariadb-corporation/mariadb-connector-nodejs/commit/7670d90949307e735c0ae148d80b3776478a599dFixvia CVE List
- github.com/mariadb-corporation/mariadb-connector-nodejs/commit/95886df9fa0cca991e2be339caa6c3979be61553Fixvia CVE List
- github.com/mariadb-corporation/mariadb-connector-nodejs/commit/e5a9d732d9574177749488336319b73074072779Fixvia CVE List
- github.com/mariadb-corporation/mariadb-connector-nodejs/releases/tag/3.2.5Fixvia CVE List
- github.com/mariadb-corporation/mariadb-connector-nodejs/releases/tag/3.3.4Fixvia CVE List
- github.com/mariadb-corporation/mariadb-connector-nodejs/releases/tag/3.4.7Fixvia CVE List
- github.com/mariadb-corporation/mariadb-connector-nodejs/releases/tag/3.5.4Fixvia CVE List
- github.com/mariadb-corporation/mariadb-connector-nodejs/security/advisories/GHSA-r3rv-jm3r-62q2Advisoryvia CVE List
- github.com/advisories/GHSA-r3rv-jm3r-62q2Advisoryvia GitHub
- hackerone.com/reports/3889197Referencevia CVE List
- jira.mariadb.org/browse/CONJS-368Referencevia CVE List