{"schema":"threatline.record/2","record":{"id":"GHSA-j456-xh4h-cpf2","aliases":["CVE-2026-109956","GHSA-j456-xh4h-cpf2"],"summary":"WekaClassifier passes an unvalidated caller-controlled model path to the weka JVM, bypassing nltk.pathsec containment","details":"## Summary\r\n`WekaClassifier` in NLTK passes a caller-controlled model file path to the weka Java VM without any `nltk.pathsec` validation. `WekaClassifier.train` puts the caller's `model_filename` verbatim into the weka argv `[\"-d\", model_filename, ...]` (weka *writes* the trained model there), and `WekaClassifier._classify_many` puts `self._model` into `[\"-l\", self._model, ...]` (weka *reads* it). Under `nltk.pathsec.ENFORCE=True` (the default on current HEAD), NLTK's stated invariant — established by advisory CVE-2026-81726 / GHSA-8mgp-746c-j5xp — is that caller-controlled model-artifact paths must be bounded to the allowed NLTK data roots before any native tool opens them. `WekaClassifier` is the one `java()`-based tool wrapper that skips this entirely, giving an untrusted workflow arbitrary-location file **write** (`-d`) and an arbitrary file **read/parse oracle** (`-l`), defeating pathsec containment.\r\n\r\nThis is a standalone, unfixed variant of the same class as CVE-2026-81726, on a code path the CVE-2026-81726 fix never touched. That advisory enumerates 6 functions (`TransitionParser.train`, `TransitionParser.parse`, `AveragedPerceptron.save`, `AveragedPerceptron.load`, `PerceptronTagger.save_to_json`, `save_maxent_params`) — `WekaClassifier` is not among them, and weka.py contains no `validate_tool_path`/`validate_model_resource` at all.\r\n\r\n## Root Cause\r\n`WekaClassifier.train(cls, model_filename, ...)` builds `cmd = [javaclass, \"-d\", model_filename, \"-t\", train_filename]` (nltk/classify/weka.py:256) and `WekaClassifier._classify_many` builds `[..., \"-l\", self._model, \"-T\", <staged>, ...]` (weka.py:131-133); `self._model` is stored unvalidated in `__init__` (weka.py:108-110). Only the internally-generated `train.arff`/`test.arff` are staged via `make_staging_dir`; the model path is passed as-is. `nltk.internals.java()` (internals.py:388-431) validates the classpath (`_verify_jar_sandbox`), the JVM launcher options (`_validate_java_options`, the CVE-2026-12841 fix), the main-class token `cmd[0]`, and rejects `@argfile` tokens in any position — but it explicitly permits program arguments starting with `-` and never inspects the interior of a program-arg path value. So `-d <path>` / `-l <path>` flow unchecked to `subprocess.Popen(final_cmd, shell=False)` and the weka JVM performs an unbounded native open/write on the caller-chosen path.\r\n\r\nSibling wrappers prove the intended pattern: `CRFTagger.train`/`set_model_file` call `validate_tool_path` (crf.py:134,300); `MaltParser.generate_malt_command` validates `-i`/`-o` via `validate_tool_path` (malt.py:340,344), its model via `validate_model_resource` (malt.py:326) and `working_dir` via `validate_path` (malt.py:206). weka.py already uses pathsec elsewhere (`validate_path` for WEKAHOME, `pathsec_open` for ARFF writes) but never for the model path.\r\n\r\n## Impact\r\nUnder `pathsec.ENFORCE=True` (default on HEAD), an untrusted workflow that chooses the weka model save/load path obtains:\r\n- Arbitrary-location file **write** via `-d` — overwrite or create a file at an attacker-chosen absolute or `..`-traversal path outside the allowed NLTK data roots (content constrained to weka's serialized-model format; the target choice is the integrity impact). This corrupts/clobbers arbitrary chosen files.\r\n- Arbitrary file **read/parse oracle** via `-l` — weka loads an out-of-root path as a model, yielding an existence/parse differential (file content is not echoed back → confidentiality impact is limited).\r\n\r\nThis defeats the pathsec containment advisory CVE-2026-81726 promises, at the same privilege level / threat model that advisory was accepted under.\r\n\r\n## Proof of Concept\r\n```python\r\nimport nltk.pathsec as ps; ps.ENFORCE = True\r\nfrom nltk.classify.weka import WekaClassifier\r\n# write-side: model written OUTSIDE any allowed NLTK data root (refused for CRFTagger, allowed here)\r\nWekaClassifier.train(\"/tmp/outside_sandbox/evil.model\",\r\n                     [({\"a\": 1}, \"pos\"), ({\"a\": 0}, \"neg\")])\r\n# read-side: -l opens an arbitrary path\r\nclf = WekaClassifier(fmt, \"/home/victim/secret.model\")\r\nclf.classify_many([{\"a\": 1}])\r\n```\r\nThe argv construction — the vulnerable step — is confirmed without weka installed (see Bypass Evidence); a configured weka.jar is needed only to observe the JVM's actual file I/O.\r\n\r\n## Attack Chain\r\n1. **Entry.** Action: an app running with `pathsec.ENFORCE=True` lets an untrusted workflow choose the weka model path and calls `WekaClassifier.train(\"../../../home/victim/x\", featuresets)` (write) or `WekaClassifier(fmt, \"/home/victim/secret.model\").classify_many(...)` (read). Guard: none — plain classmethod/constructor parameter (weka.py:230,108-110). Bypass proof: grep shows weka.py uses no `validate_tool_path`/`validate_model_resource`/`validate_tool_dir` (NONE).\r\n2. **Command build.** Action: the path is placed into `cmd = [javaclass, \"-d\", model_filename, \"-t\", train_filename]` (weka.py:256) / `[\"-l\", self._model, ...]`. Guard: only the internally-generated `train.arff` is staged via `make_staging_dir`; the model path is passed as-is. Bypass proof: runtime capture yielded `['weka.classifiers.bayes.NaiveBayes', '-d', '/tmp/outside_sandbox_weka.model', '-t', '<staged>/train.arff']` — the raw out-of-root path is `cmd[2]`.\r\n3. **java() sink.** Action: `java(cmd, classpath=_weka_classpath, ...)` → `subprocess.Popen(final_cmd)` (internals.py:431). Guard: `java()` validates classpath, JVM `options`, `cmd[0]`, and rejects `@argfile` tokens. Bypass proof: none of these inspect the `-d`/`-l` program-arg value; internals.py explicitly documents that program args after the main class may start with `-`, and the path is neither `cmd[0]` nor an `@`-token, so every `java()` gate passes. Negative control: the same path through `validate_tool_path(..., for_write=True, must_exist=False)` raises `PermissionError`.\r\n4. **Impact.** Action: the weka JVM opens the path outside the allowed roots → arbitrary-location write (`-d`) / parse-existence oracle (`-l`). Guard: pathsec is never consulted (no `validate_tool_path`, no `pathsec_open`). Bypass proof: the directly-analogous sibling `CRFTagger.train` calls `validate_tool_path(model_file, must_exist=False)` (crf.py:300); weka does not, and commit `ee6d6138` hardened weka's other sinks (scratch files, WEKAHOME jar) while leaving the model path unvalidated.\r\n\r\n## Bypass Evidence\r\n- Negative control (guard is real): `validate_tool_path(\"/tmp/outside_sandbox_weka.model\", for_write=True, must_exist=False)` → `PermissionError`; `validate_tool_path(\"../../../home/victim/.ssh/authorized_keys\", ...)` → `PermissionError`.\r\n- Sink reached unvalidated (guard absent): captured write-side argv `['weka.classifiers.bayes.NaiveBayes', '-d', '/tmp/outside_sandbox_weka.model', '-t', '<staged>/train.arff']` and read-side `[..., '-l', '/home/victim/secret.model', '-T', '<staged>/test.arff', '-p', '0']`.\r\n- Version: `git show v3.10.3:nltk/classify/weka.py` contains both the `-d` model-path build (line 235) and the `-l` read, and NO `validate_tool_path`.\r\n\r\n## Affected Versions\r\n`<= 3.10.3` (present on the latest release tag v3.10.3 and on HEAD `c06cd264`). No published fix has ever targeted the weka `-d`/`-l` model path; commits after v3.10.3 (`ee6d6138`, `92aeada6`, `a9752559`) touched weka.py for other sinks but did not add model-path validation.\r\n\r\n## Suggested Fix\r\nBefore building the `-d`/`-l`/`-T` command, validate the model path with pathsec, mirroring `CRFTagger`/`MaltParser`:\r\n```python\r\nvalidate_tool_path(model_filename, context=\"WekaClassifier.train\", for_write=True, must_exist=False)\r\nvalidate_tool_path(self._model, context=\"WekaClassifier._classify_many\")\r\n```\r\n\r\n\r\n---\r\nReported by **zx (Jace)** — GitHub: @manus-use\r\n\r\n## Fix status (2026-09-28)\r\n\r\nStatus: MERGED on develop (unreleased; v3.10.3 of 2026-08-12 predates the fix).\r\n\r\nPR: #3863 \"Bound the WekaClassifier model path to the pathsec data roots\", merged 2026-09-06, merge commit bc2878725 on develop. Fix commit: 6a1760629.\r\n\r\nProbe: nltk/test/unit/security_probes/ghsa_j456_xh4h_cpf2.py, added by PR #3905 \"Add GHSA-j456 live probe; expand the GHSA-8mgp probe attack set\" (commit a96715264, merged 2026-09-20, merge commit 84d987bf8); verdict on develop 2fa3f48fe: FIXED (WekaClassifier -l and -d refuse out-of-root model paths).\r\n\r\nRelease: none yet; no release tag contains 6a1760629.\r\n","categories":["Libraries & packages"],"product":"nltk","vendor":"","ecosystem":"pip","affected_ranges":[{"source":"GitHub Advisory Database","source_url":"https://github.com/advisories/GHSA-j456-xh4h-cpf2","source_modified_at":"2026-10-27T14:50:31Z","fetched_at":"2026-10-27T16:27:21.584480Z","package":{"ecosystem":"pip","name":"nltk"},"range":"<= 3.10.3"},{"source":"GitHub Advisory Database","source_url":"https://github.com/nltk/nltk/security/advisories/GHSA-j456-xh4h-cpf2","source_modified_at":"2026-10-26T07:35:54Z","fetched_at":"2026-10-27T10:24:27.527526Z","package":{"ecosystem":"pip","name":"nltk"},"range":"<= 3.10.3"},{"source":"OSV","source_url":"https://osv.dev/vulnerability/GHSA-j456-xh4h-cpf2","source_modified_at":"2026-10-27T15:00:05.453940749Z","fetched_at":"2026-10-27T16:27:21.584480Z","package":{"name":"nltk","ecosystem":"PyPI","purl":"pkg:pypi/nltk"},"ranges":[{"type":"ECOSYSTEM","events":[{"introduced":"0"},{"fixed":"3.10.4"}]}],"versions":["0.8","0.9","0.9.3","0.9.4","0.9.5","0.9.6","0.9.7","0.9.8","0.9.9","2.0.1","2.0.1rc1","2.0.1rc2-git","2.0.1rc3","2.0.1rc4","2.0.2","2.0.3","2.0.4","2.0.5","2.0b4","2.0b5","2.0b6","2.0b7","2.0b8","2.0b9","3.0.0","3.0.0b1","3.0.0b2","3.0.1","3.0.2","3.0.3","3.0.4","3.0.5","3.1","3.10.0","3.10.1","3.10.2","3.10.3","3.2","3.2.1","3.2.2","3.2.3","3.2.4","3.2.5","3.3","3.4","3.4.1","3.4.2","3.4.3","3.4.4","3.4.5"]}],"fixed_versions":[{"source":"GitHub Advisory Database","source_url":"https://github.com/advisories/GHSA-j456-xh4h-cpf2","source_modified_at":"2026-10-27T14:50:31Z","fetched_at":"2026-10-27T16:27:21.584480Z","package":{"ecosystem":"pip","name":"nltk"},"version":"3.10.4"},{"source":"OSV","source_url":"https://osv.dev/vulnerability/GHSA-j456-xh4h-cpf2","source_modified_at":"2026-10-27T15:00:05.453940749Z","fetched_at":"2026-10-27T16:27:21.584480Z","package":{"name":"nltk","ecosystem":"PyPI","purl":"pkg:pypi/nltk"},"version":"3.10.4"}],"cvss":8.6,"severity":"High","kev":{"listed":false},"epss":{"probability":null,"percentile":null,"score_date":null},"published_at":"2026-10-27T14:50:30Z","modified_at":"2026-10-27T15:00:05.453940749Z","provenance":[{"source":"GitHub Advisory Database","url":"https://github.com/advisories/GHSA-j456-xh4h-cpf2","fetched_at":"2026-10-27T16:27:21.584480Z","source_modified_at":"2026-10-27T14:50:31Z"},{"source":"GitHub Advisory Database","url":"https://github.com/nltk/nltk/security/advisories/GHSA-j456-xh4h-cpf2","fetched_at":"2026-10-27T10:24:27.527526Z","source_modified_at":"2026-10-26T07:35:54Z"},{"source":"OSV","url":"https://osv.dev/vulnerability/GHSA-j456-xh4h-cpf2","fetched_at":"2026-10-27T16:27:21.584480Z","source_modified_at":"2026-10-27T15:00:05.453940749Z"}],"sources":["GitHub Advisory Database","OSV"],"references":[{"url":"https://github.com/nltk/nltk/security/advisories/GHSA-j456-xh4h-cpf2","source":"GitHub Advisory Database"},{"url":"https://github.com/nltk/nltk/pull/3863","source":"GitHub Advisory Database"},{"url":"https://github.com/nltk/nltk/commit/6a17606293fe9d3ea1006f99dd3fed2e2b25d519","source":"GitHub Advisory Database"},{"url":"https://github.com/nltk/nltk/releases/tag/v3.10.4","source":"GitHub Advisory Database"},{"url":"https://github.com/advisories/GHSA-j456-xh4h-cpf2","source":"GitHub Advisory Database"}],"locations":[],"motoko_assessment":{"status":"requires_architecture_review","automatic_remediation":false},"classification":{"method":"product-first software-layer rules","rules_version":"2.1","matched_on":"ecosystem","confidence":"heuristic","reviewed":false},"change_timestamp":"2026-10-27T15:00:05.453940749Z","content_hash":"556c8a39344b5d2c3c713fdb53e0ea8d9c9422550b625a208c0a510a6fa05e86"}}