{"schema":"threatline.record/2","record":{"id":"GHSA-7wpf-ch8f-5f4x","aliases":["GHSA-7wpf-ch8f-5f4x"],"summary":"SSRF via absolute signalk.appIcon URL in the app store icon fetcher","details":"### Summary\n\nThe app store icon code (`dist/appstore/icon-probe.js` around line 200 and `icon-bytes.js` around line 138) resolves a plugin's declared `signalk.appIcon`. Relative paths are pinned to the CDN, but an absolute http(s) URL is used as-is: the server fetches it, follows redirects, and stores any `image/*` response as the plugin's icon, which is then served to the admin UI. Unrelated to GHSA-q59x-jc9f-gfqf.\n\n### Affected\n\nsignalk-server 2.33.0 (latest).\n\n### Reproduction\n\nThe real dist modules driven directly, Docker with `--network none`; a local \"internal\" service on 127.0.0.1 logs requests:\n\n```\n[CONTROL relative] declared=../../icon.png\n  resolved=null\n  internal-service hits: []  stored: null\n[ATTACK absolute] declared=http://127.0.0.1:35013/latest/meta-data/iam\n  resolved=http://127.0.0.1:35013/latest/meta-data/iam\n  internal-service hits: [\"GET /latest/meta-data/iam\"]  stored: .../icon-bytes/evil-plugin@1.0.0.png (70 bytes)\n[ATTACK redirect] declared=http://127.0.0.1:35013/redir\n  internal-service hits: [\"GET /redir\",\"GET /internal-secret-via-redirect.png\"]  stored: .../icon-bytes/evil-plugin@1.0.0.png (70 bytes)\n```\n\nI drove the modules rather than a full running server.\n\n### Impact\n\nAnyone who can get a plugin listed in the app store (publishing an npm package with the signalk keywords) can make every signalk-server that browses the app store send requests to internal addresses on the vessel network and to cloud metadata endpoints. Responses with an image content type are stored and served back.\n\n### Suggested fix\n\nOnly accept relative icon paths resolved against the CDN (or an https allowlist of known hosts), do not follow redirects to other hosts, and reject private, loopback and link-local addresses after resolution.\n\nFound with AploSec.\n\nReported by Zachariah Mithani (zachariah@aplosai.com).","categories":["Unclassified"],"product":"signalk-server","vendor":"","ecosystem":null,"affected_ranges":[{"source":"GitHub Advisory Database","source_url":"https://github.com/SignalK/signalk-server/security/advisories/GHSA-7wpf-ch8f-5f4x","source_modified_at":"2026-10-18T19:17:28Z","fetched_at":"2026-10-23T20:39:26.410340Z","package":{"ecosystem":"npm","name":"signalk-server"},"range":"<= 2.33.0"}],"fixed_versions":[],"cvss":4.2,"severity":"Medium","kev":{"listed":false},"epss":{"probability":null,"percentile":null,"score_date":null},"published_at":"2026-10-18T19:17:28Z","modified_at":"2026-10-18T19:17:28Z","provenance":[{"source":"GitHub Advisory Database","url":"https://github.com/SignalK/signalk-server/security/advisories/GHSA-7wpf-ch8f-5f4x","fetched_at":"2026-10-23T20:39:26.410340Z","source_modified_at":"2026-10-18T19:17:28Z"}],"sources":["GitHub Advisory Database"],"references":[],"locations":[],"motoko_assessment":{"status":"requires_architecture_review","automatic_remediation":false},"classification":{"method":"product-first software-layer rules","rules_version":"2.1","matched_on":null,"confidence":"unknown","reviewed":false},"change_timestamp":"2026-10-18T19:17:28Z","content_hash":"db81fe538946eb1b3a8a3f98556026be167a20cb6885a90c72ab9ced1799fe34"}}